[client] Fix inconsistent parameter of TopicPolicies.getSubscriptionDispatchRate #15293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Apr 25, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Apr 28, 2022
(cherry picked from commit 14ba6c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
getSubscriptionDispatchRateandgetSubscriptionDispatchRateAsyncinorg.apache.pulsar.client.admin.TopicPoliciesuse "namespace" in parameter,but the implementation in
org.apache.pulsar.client.admin.internal.TopicPoliciesImpluses "topic".This should be a typo. "Topic" should be used.
Modifications
Use "topic" instead of "namespace".
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docfix typo and doc error.