Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] Make some methods of ClusterBase pure async. #15358

Merged
merged 9 commits into from
May 10, 2022
Merged

[improve][broker] Make some methods of ClusterBase pure async. #15358

merged 9 commits into from
May 10, 2022

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Apr 28, 2022 •
edited
Loading

Motivation

See PIP #14365 and change tracker #15043.

Modifications

  • Make ClusterBase setPeerClusterNames / getPeerCluster / deleteCluster methods to pure async.

Verifying this change

  • Make sure that the change passes the CI checks.

AdminApi2Test#testPeerCluster and AdminTest#clusters already cover this change.

Documentation

  • no-need-doc
    (Please explain why)

@mattisonchao mattisonchao marked this pull request as draft April 28, 2022 00:57
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 28, 2022
@mattisonchao mattisonchao mentioned this pull request Apr 28, 2022
Closed
26 tasks
@mattisonchao mattisonchao added this to the 2.11.0 milestone May 4, 2022
@mattisonchao mattisonchao added area/broker area/admin type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels May 4, 2022
@mattisonchao mattisonchao marked this pull request as ready for review May 4, 2022 20:38
@mattisonchao mattisonchao requested a review from RobertIndie May 9, 2022 06:40
shibd
shibd approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@shibd shibd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

gaoran10
gaoran10 reviewed May 9, 2022
View reviewed changes
Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Left some trivial comments.

pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java Outdated Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java Outdated Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java Outdated Show resolved Hide resolved
@mattisonchao mattisonchao requested a review from gaoran10 May 10, 2022 01:36
gaoran10
gaoran10 approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattisonchao mattisonchao merged commit d7a4f7f into apache:master May 10, 2022
@sijie sijie mentioned this pull request Aug 1, 2022
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shibd shibd shibd approved these changes

@gaoran10 gaoran10 gaoran10 approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@RobertIndie RobertIndie Awaiting requested review from RobertIndie

Assignees

@mattisonchao mattisonchao

Labels
area/admin area/broker doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mattisonchao @Technoboy- @gaoran10 @shibd