[cherry-pick][pulsar-sql] Java version trim agent presto332 branch2.8 #15373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e#15236) Fix apache#14951 The presto 332 couldn't parse Java version like this `11.0.14.1`, so add a Java version trim agent to walk around the problem. This is a temporary patch, after the presto upgrade to 332+, we could remove this. Add a Java version trim agent to format the system property `java.version` for the Pulsar SQL plugin. (cherry picked from commit a1aa18f)
gaoran10
requested review from
lhotari,
BewareMyPower,
codelipenghui,
eolivelli,
hangc0276,
Technoboy- and
zymap
merlimat
approved these changes
Apr 28, 2022
merlimat
added
the
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14951
Motivation
The presto 332 couldn't parse Java version like this
11.0.14.1, so add a Java version trim agent to walk around the problem.This is a temporary patch, after the presto upgrade to 332+, we could remove this.
(cherry picked from commit a1aa18f)
Modifications
Add a Java version trim agent to format the system property
java.versionfor the Pulsar SQL plugin.Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
no-need-doc(Please explain why)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)