Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Add verification for configured default backlog quota and retention #15441

Conversation

codelipenghui
Copy link
Contributor

Motivation

Add verification for configured default backlog quota and data retention, to keep consistent with
the namespace level policy and topic level policy.

Modifications

Add verification for the backlog quota and retention of size and time duration while starting Pulsar.

Verifying this change

Added a new test to verify the different situations.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: ( no)
  • The admin cli options: (no)
  • Anything that affects deployment: (yes)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • no-need-doc
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-added
    (Docs have been already added)

@codelipenghui codelipenghui self-assigned this May 5, 2022
@codelipenghui codelipenghui added area/broker release/important-notice The changes which are important should be mentioned in the release note labels May 5, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 5, 2022
@codelipenghui codelipenghui added this to the 2.11.0 milestone May 5, 2022
@codelipenghui codelipenghui added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label May 5, 2022
@codelipenghui codelipenghui merged commit d5373d8 into apache:master May 5, 2022
@codelipenghui codelipenghui deleted the penghui/validate_retention_backlog branch May 5, 2022 11:13
@lhotari lhotari mentioned this pull request May 6, 2022
@codelipenghui codelipenghui restored the penghui/validate_retention_backlog branch May 17, 2022 01:20
@codelipenghui codelipenghui deleted the penghui/validate_retention_backlog branch May 17, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs release/important-notice The changes which are important should be mentioned in the release note type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants