-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIP-161 Exclusive Producer: ability to fence out an existing Producer (ExclusiveWithFencing mode) #15488
PIP-161 Exclusive Producer: ability to fence out an existing Producer (ExclusiveWithFencing mode) #15488
Conversation
@eolivelli:Thanks for your contribution. For this PR, do we need to update docs? |
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ExclusiveProducerTest.java
Show resolved
Hide resolved
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerAccessMode.java
Outdated
Show resolved
Hide resolved
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilder.java
Outdated
Show resolved
Hide resolved
It changed the protocol and public API, I'm not sure if we need a proposal for it. |
@momo-jun a soft reminder: here is a PR w/ doc-required label, could u pls follow up? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I don't like ExclusiveWithFencing
too much though I cannot come up with a better suggestion.
For the "doc-required" label, it's needed to remember updating the docs. eg: https://pulsar.apache.org/docs/en/concepts-messaging/#access-mode
Finally, as @mattisonchao mentioned, this is touching public API so it would be good to have a PIP discussion and vote.
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerAccessMode.java
Outdated
Show resolved
Hide resolved
@eolivelli I can add docs for this PR as soon as it is approved/merged. If you'd like to do it, feel free to ping me for review. Either way works for me. |
83c14f0
to
42808ea
Compare
I have updated that section, thanks for the reminder. |
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
thank you @Anonymitaet. I have committed your suggestion |
@merlimat @mattisonchao @Anonymitaet please take another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/pulsarbot rerun-failure-checks |
/pulsarbot rerun-failure-checks |
2 similar comments
/pulsarbot rerun-failure-checks |
/pulsarbot rerun-failure-checks |
Motivation
Currently (in 2.10) we have two ways of creating a Exclusive Producer: Exclusive and WaitForExclusive.
We are missing a mode in which the new Producer fences out any existing producer, allowing to apply Optimistic Locking pattern.
Linked PIP: #15528
Modifications
Verifying this change
This change added tests.