-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker]Sync topicPublishRateLimiter update #15599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonHxy
force-pushed
the
sync_topicPublishRateLimter
branch
from
May 14, 2022 06:36
98f2d17
to
9458fe0
Compare
/pulsarbot run-failure-checks |
AnonHxy
force-pushed
the
sync_topicPublishRateLimter
branch
from
May 14, 2022 14:07
9458fe0
to
cdaac52
Compare
/pulsarbot run-failure-checks |
AnonHxy
force-pushed
the
sync_topicPublishRateLimter
branch
2 times, most recently
from
May 16, 2022 02:58
4ddbc98
to
2726281
Compare
/pulsarbot run-failure-checks |
2 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
AnonHxy
force-pushed
the
sync_topicPublishRateLimter
branch
from
May 16, 2022 18:03
2726281
to
0d3c41e
Compare
/pulsarbot run-failure-checks |
@Technoboy- @Jason918 @HQebupt PTAL |
/pulsarbot run-failure-checks |
@gaozhangmin @codelipenghui PTAL~ |
Jason918
approved these changes
May 25, 2022
2 tasks
Jason918
added
type/bug
The PR fixed a bug or issue reported a bug
release/2.10.1
labels
May 28, 2022
codelipenghui
pushed a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jun 7, 2022
(cherry picked from commit 51e727f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-2.10
doc-not-needed
Your PR changes do not impact docs
release/2.10.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Synchronized update
topicPublishRateLimiter
in case of race condtion.There is a race condtion when two threads update
topicPublishRateLimiter
concurrency:topicPublishRateLimiter
is null at the beginningpublishThrottlingRateInByte < 0
andpublishThrottlingRateInMsg < 0
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
Line 1170 in 7bdfa3a
publishThrottlingRateInByte > 0
orpublishThrottlingRateInMsg > 0
topicPublishRateLimiter
a new limiter.PublishRateLimiter.DISABLED_RATE_LIMITER
. Then the new limiter setted by thread2 will never be accessed, which will produce resource leakagesModifications
Synchronized method
updatePublishDispatcher
Verifying this change
Documentation
no-need-doc