[improve][broker] Make some operation SubscribeRate methods in Namespaces async #15656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shibd PTAL |
gaoyanliang
force-pushed
the
async_subscriberate_namespace
branch
from
05118cd to
4ffbbb0
Compare
shibd
reviewed
May 19, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Outdated
Show resolved
Hide resolved
|
@shibd All suggested fixed. PTAL. |
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
|
@mattisonchao OK, I'll try it. There is no unit test for the v2 Namespaces yet, I will try to add it, it may take some time. |
Technoboy-
added
type/enhancement
gaoyanliang
force-pushed
the
async_subscriberate_namespace
branch
from
dbcf10c to
dcdf075
Compare
gaoyanliang
force-pushed
the
async_subscriberate_namespace
branch
from
dcdf075 to
def3cff
Compare
|
@shibd @mattisonchao PTAL. |
|
Hi @mattisonchao Can you help trigger the ci ？ |
Technoboy-
approved these changes
May 27, 2022
|
Hi @Technoboy- Can you help trigger the ci ？ |
Yes, I have triggered. |
Thanks |
|
/pulsarbot run-failure-checks |
26 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See PIP #14365 and change tracker #15043.
Make NamespacesBase deleteSubscribeRate / setSubscribeRate / getSubscribeRate methods to pure async.
Documentation
no-need-doc