[fix][sql] Fix the decimal type error convert in json schema #15687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
May 20, 2022
codelipenghui
added
release/2.9.3
release/2.10.1
type/bug
Technoboy-
approved these changes
May 21, 2022
|
/pulsarbot run-failure-checks |
mattisonchao
approved these changes
May 24, 2022
codelipenghui
pushed a commit
that referenced
this pull request
May 26, 2022
### Motivation
In the current sql implementation, If using `JSON` schema and querying for decimal type, there will be the following two errors:
1. The data type is displayed as varchar.
2. Loss of precision because scientific notation is used to display.
```
presto> select bigdecimal, typeof(bigdecimal) as devimal_type from pulsar."public/default".test_avro2;
bigdecimal | devimal_type
-----------------------+--------------
1.2345678912345678E36 | varchar
1.2345678912345678E36 | varchar
(2 rows)
```
The original data is: `1234567891234567891234567891234567.89`
### Modifications
- When getting jsonNode, use `BIG_DECIMAL` instead of float and double.
- `PulsarJsonFieldDecoder` increases the processing of Decimal types
(cherry picked from commit 0c6e2ca)
codelipenghui
pushed a commit
that referenced
this pull request
May 26, 2022
In the current sql implementation, If using `JSON` schema and querying for decimal type, there will be the following two errors:
1. The data type is displayed as varchar.
2. Loss of precision because scientific notation is used to display.
```
presto> select bigdecimal, typeof(bigdecimal) as devimal_type from pulsar."public/default".test_avro2;
bigdecimal | devimal_type
-----------------------+--------------
1.2345678912345678E36 | varchar
1.2345678912345678E36 | varchar
(2 rows)
```
The original data is: `1234567891234567891234567891234567.89`
- When getting jsonNode, use `BIG_DECIMAL` instead of float and double.
- `PulsarJsonFieldDecoder` increases the processing of Decimal types
(cherry picked from commit 0c6e2ca)
nicoloboschi
added a commit
to nicoloboschi/pulsar
that referenced
this pull request
May 26, 2022
…pache#15687)" This reverts commit fb42686.
5 tasks
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2022
…15687) ### Motivation In the current sql implementation, If using `JSON` schema and querying for decimal type, there will be the following two errors: 1. The data type is displayed as varchar. 2. Loss of precision because scientific notation is used to display. ``` presto> select bigdecimal, typeof(bigdecimal) as devimal_type from pulsar."public/default".test_avro2; bigdecimal | devimal_type -----------------------+-------------- 1.2345678912345678E36 | varchar 1.2345678912345678E36 | varchar (2 rows) ``` The original data is: `1234567891234567891234567891234567.89` ### Modifications - When getting jsonNode, use `BIG_DECIMAL` instead of float and double. - `PulsarJsonFieldDecoder` increases the processing of Decimal types (cherry picked from commit 0c6e2ca) (cherry picked from commit 618d4e2)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the current sql implementation, If using
JSONschema and querying for decimal type, there will be the following two errors:The original data is:
1234567891234567891234567891234567.89Modifications
BIG_DECIMALinstead of float and double.PulsarJsonFieldDecoderincreases the processing of Decimal typesDocumentation
no-need-doc(Please explain why)