[improve][broker]tidy update subscriptions dispatcher rate-limiter #15789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc
AnonHxy
force-pushed
the
opt_update_sub_dispatcher_ratelimter
branch
from
2c0b1b7 to
e1de5ad
Compare
Technoboy-
removed
the
doc
4 tasks
4 tasks
Jason918
requested changes
May 28, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
Jason918
approved these changes
May 30, 2022
|
/pulsarbot run-failure-checks |
AnonHxy
changed the title
|
/pulsarbot run-failure-checks |
AnonHxy
force-pushed
the
opt_update_sub_dispatcher_ratelimter
branch
from
d28d0d7 to
f1b14a9
Compare
|
/pulsarbot run-failure-checks |
|
@AnonHxy Please help create a PR for branch-2.10, I'm not able to cherry-pick it due to lots of conflicts with branch-2.10 |
AnonHxy
added a commit
to AnonHxy/pulsar
that referenced
this pull request
Jul 25, 2022
5 tasks
The PR has been created, PTAL @codelipenghui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
updateSubscriptionsDispatcherRateLimiter(), which will make the code more clearModifications
Create
updateSubscriptionsDispatcherRateLimiter()to update subscriptions dispatcher rate-limiter on both topic-level and namespace-levelVerifying this change
Documentation
no-need-docdoc-not-needed