Extracted interface for EntryCacheManager #15933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/cleanup
merlimat
added
doc-not-needed
Jason918
approved these changes
Jun 6, 2022
codelipenghui
approved these changes
Jun 6, 2022
|
/pulsarbot run-failure-checks |
Technoboy-
approved these changes
Jun 6, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 8, 2022
* Extracted interface for EntryCacheManager * Fixed references * added more methods to the interface * Fixed mocked test * Removed unused import * Fixed wrong casting in reflection access (cherry picked from commit c7faf62)
congbobo184
pushed a commit
that referenced
this pull request
Nov 17, 2022
* Extracted interface for EntryCacheManager * Fixed references * added more methods to the interface * Fixed mocked test * Removed unused import * Fixed wrong casting in reflection access (cherry picked from commit c7faf62)
congbobo184
added
release/2.9.4
cherry-picked/branch-2.9
congbobo184
pushed a commit
that referenced
this pull request
Dec 7, 2022
* Extracted interface for EntryCacheManager * Fixed references * added more methods to the interface * Fixed mocked test * Removed unused import * Fixed wrong casting in reflection access (cherry picked from commit c7faf62)
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactored code to extract an interface for
EntryCacheManagerinstead of relying on a concrete class implementation without any functional changes.The new interface will be used to add more cache implementations.