Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] make publish rate and dispatch rate operation async #15946

Conversation

zhangqian321
Copy link
Contributor

@zhangqian321 zhangqian321 commented Jun 6, 2022

Motivation

See PIP #14365 and change tracker #15043.

Make removePublishRate / getPublishRate / getDispatchRate / setDispatchRate / deleteDispatchRate methods in NamespacesBase to pure async.

Documentation

  • doc-not-needed

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

@zhangqian321:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@Technoboy- Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/admin doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jun 9, 2022
@Technoboy- Technoboy- added this to the 2.11.0 milestone Jun 9, 2022
Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for your contribution.

@Technoboy- Technoboy- requested a review from mattisonchao June 9, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants