[fix][admin]allowAutoTopicCreation and allowAutoTopicCreationType etc should be dynamically configured #16023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ationType etc should be dynamically configured
github-actions
bot
added
doc-complete
There was a problem hiding this comment.
The change looks good. Could you please add a UT for the new change?
Here is an example PR #13121 which added subscriptionTypesEnabled dynamic configuration support.
Anonymitaet
added
doc
OK, I will supplement the corresponding unit tests as soon as possible |
…ts. add description of brokerDeleteInactivePartitionedTopicMetadataEnabled to doc.
Radiancebobo
added a commit
to Radiancebobo/pulsar
that referenced
this pull request
Jun 13, 2022
Radiancebobo
force-pushed
the
topicConfigDynamically
branch
from
3dd5565 to
b6f768c
Compare
codelipenghui
requested review from
eolivelli,
Jason918,
315157973,
aloyszhang,
gaoran10 and
Technoboy-
|
Unit tests that fail to run also happen on the master branch, it doesn't look like it's caused by my commits, I'll try my best to take the time to fix them. |
AnonHxy
approved these changes
Jun 15, 2022
...roker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java
Outdated
Show resolved
Hide resolved
...roker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java
Outdated
Show resolved
Hide resolved
...roker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Kai Wang <kwang@streamnative.io>
…topicConfigDynamically
|
/pulsarbot run-failure-checks |
Demogorgon314
approved these changes
Jun 23, 2022
|
/pulsarbot run-failure-checks |
shibd
approved these changes
Jun 30, 2022
github-actions
bot
added
doc-complete
BewareMyPower
requested changes
Jul 1, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoSubscriptionCreationTest.java
Outdated
Show resolved
Hide resolved
|
@Radiancebobo Please select only one documentation label for your PR. |
BewareMyPower
requested changes
Jul 1, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java
Outdated
Show resolved
Hide resolved
…gestions from code review
…gestions from code review
ok |
…gestions from code review
BewareMyPower
approved these changes
Jul 1, 2022
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
@BewareMyPower Can you help me merge this branch to master? |
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Jul 5, 2022
… should be dynamically configured (apache#16023)
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
… should be dynamically configured (apache#16023)
4 tasks
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 18, 2025
… should be dynamically configured (apache#16023) (cherry picked from commit 0d8c7ef) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Mar 18, 2025
… should be dynamically configured (apache#16023) (cherry picked from commit 0d8c7ef) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Mar 18, 2025
… should be dynamically configured (apache#16023) (cherry picked from commit 0d8c7ef) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowAutoTopicCreation and allowAutoTopicCreationType etc should be dynamically configured
Fixes #16020
Motivation
In the broker.conf configuration, there are these configurations:
I think these should be dynamically configurable.
Pulsar has namespace-level policy, but the broker-level dynamically configuration is missing.
Modifications
The change is very simple, just add dynamic identification to these configurations in ServiceConfiguration.java, and add a callback function when updating.
Documentation
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-complete(Docs have been already added)