Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.10][fix][admin] Fix producer/consume permission can’t get schema #16026

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

Technoboy-
Copy link
Contributor

Cherry-pick #15956.

Motivation

Currently, we need admin permissions to operate the schema API. This is because the admin permission was defined when the schema API was first added. See #1381.
Later, then adding authentication granularity with #6428, we don't change the schema API part. So leave the admin permission today.

But the binary protocol allows the produce/consume permission to get the schema, so change the related method permission to produce/consume.

Modifications

  • get schema need GET_METADATA permission

Documentation

  • doc-not-needed
    (Please explain why)

@Technoboy- Technoboy- marked this pull request as ready for review June 13, 2022 02:01
@Technoboy- Technoboy- self-assigned this Jun 13, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 13, 2022
@codelipenghui codelipenghui added area/security release/2.10.1 release/important-notice The changes which are important should be mentioned in the release note type/bug The PR fixed a bug or issue reported a bug cherry-picked/branch-2.10 labels Jun 13, 2022
@codelipenghui codelipenghui merged commit f3b4e86 into apache:branch-2.10 Jun 13, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jun 13, 2022
…#15956) (apache#16026)

Cherry-pick apache#15956.
### Motivation
Currently, we need admin permissions to operate the schema API. This is because the admin permission was defined when the schema API was first added. See apache#1381.
Later, then adding authentication granularity with apache#6428, we don't change the schema API part.  So leave the admin permission today.

But the binary protocol allows the produce/consume permission to get the schema, so change the related method permission to `produce/consume`.

(cherry picked from commit f3b4e86)
@Technoboy- Technoboy- deleted the cherry-pick-15956 branch August 10, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs release/important-notice The changes which are important should be mentioned in the release note release/2.10.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants