Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][doc] Add docs for failure domain + anti-affinity namespace #16069

Merged
merged 9 commits into from
Jun 20, 2022

Conversation

momo-jun
Copy link
Contributor

@momo-jun momo-jun commented Jun 15, 2022

Modifications

  1. Fix [Doc] Add concepts to explain failure domain and anti-affinity group #15629 - Add docs and illustrations for anti-affinity namespace and failure domain, and apply to versioned docs since 2.8.0.
  2. Re-org the Load Balance topic with a few more updates:
    a) rename the topic title, remove the original heading2 titles, and elevate all the subheadings.
    b) clarify the mandatory/optional configs for bundle split algorithms.
    c) move the "unload" section behind the "auto shed load" section.
  3. Fix [Doc] Load Balancer - Broker overload thresholds does not apply to some Shedding algorithms #15904 - Clarify the scope of loadBalancerBrokerOverloadedThresholdPercentage.

The preview looks good.
image
image

Documentation

  • doc

@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jun 16, 2022
@momo-jun momo-jun marked this pull request as ready for review June 17, 2022 01:54
@momo-jun
Copy link
Contributor Author

Ping @Anonymitaet for review.


```shell
To enable bundle split, you need to configure the following settings in the `broker.conf` file, and set `defaultNamespaceBundleSplitAlgorithm` based on your needs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we configure them in standalone.conf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the answer is "no", because load balance is only required when you have multiple brokers. @Demogorgon314 is it true?

Copy link
Contributor

@liangyuanpeng liangyuanpeng Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load balance is only required when you have multiple brokers

Yes, The config of load balance is unnecessary on standalone.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@momo-jun Yes, you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
4 participants