PIP-105: new API to get subscription properties #16095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason918
reviewed
Jun 20, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
Outdated
Show resolved
Hide resolved
eolivelli
added a commit
to datastax/pulsar
that referenced
this pull request
Jun 21, 2022
(cherry picked from commit face8bb)
liangyepianzhou
pushed a commit
that referenced
this pull request
Dec 7, 2022
(cherry picked from commit face8bb)
liangyepianzhou
added a commit
that referenced
this pull request
Dec 7, 2022
This reverts commit d2ff293.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In PIP-105 we added support for Subscription Properties. You can read them using the "stats" command, but it is not very user friendly.
Modifications
This patch adds a specific REST API to get the properties and a pulsar-admin command
Verifying this change
This change added tests
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-needed(Please explain why)
REST API and pulsar-admin docs are generated automatically