Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Docker Maven plugin from Spotify to fabric8 #16099

Closed
wants to merge 1 commit into from
Closed

Changed Docker Maven plugin from Spotify to fabric8 #16099

wants to merge 1 commit into from

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Jun 16, 2022 •
edited by github-actions bot
Loading

Motivation

The maven plugin com.spotify:dockerfile-maven-plugin that we are using to build Docker images has been discontinued and not supported for quite some time. There are also things that don't work anymore with this plugin, like for example building on M1 Mac with an ARM based JVM.

The suggested replacement is io.fabric8:docker-maven-plugin (https://dmp.fabric8.io) which is actively mantained.

  • doc-not-needed

@merlimat merlimat added this to the 2.11.0 milestone Jun 16, 2022
@merlimat merlimat self-assigned this Jun 16, 2022
@github-actions
Copy link

@merlimat Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@merlimat merlimat added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jun 16, 2022
nicoloboschi
nicoloboschi approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

michaeljmarshall
michaeljmarshall approved these changes Jul 9, 2022
View reviewed changes
Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merlimat merlimat mentioned this pull request Jul 19, 2022
Closed
5 tasks
@tisonkun tisonkun mentioned this pull request Jul 20, 2022
Closed
@codelipenghui codelipenghui modified the milestones: 2.11.0, 2.12.0 Jul 26, 2022
@mattisonchao mattisonchao reopened this Jul 26, 2022
@mattisonchao
Copy link
Member

Re-open this PR to rerun the test.

@mattisonchao
Copy link
Member

@merlimat Could you please check the failed test?

eolivelli
eolivelli approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli
Copy link
Contributor

CI is failing while building the docker image. maybe we have to fine tune this patch

2022-07-29T02:07:11.1326799Z [INFO] ------------------------------------------------------------------------
2022-07-29T02:07:11.1442724Z [ERROR] Failed to execute goal on project pulsar-all-docker-image: Could not resolve dependencies for project org.apache.pulsar:pulsar-all-docker-image:pom:2.11.0-SNAPSHOT: Could not find artifact org.apache.pulsar:pulsar-docker-image:jar:docker-info:2.11.0-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1]
2022-07-29T02:07:11.1444564Z [ERROR]

cc @lhotari @merlimat

@codelipenghui codelipenghui removed this from the 2.11.0 milestone Aug 1, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Aug 1, 2022
@tisonkun tisonkun mentioned this pull request Aug 17, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@hezhangjian hezhangjian hezhangjian approved these changes

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@liangyuanpeng liangyuanpeng liangyuanpeng approved these changes

@michaeljmarshall michaeljmarshall michaeljmarshall approved these changes

@mattisonchao mattisonchao mattisonchao approved these changes

@lhotari lhotari Awaiting requested review from lhotari

@hangc0276 hangc0276 Awaiting requested review from hangc0276

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@BewareMyPower BewareMyPower Awaiting requested review from BewareMyPower

Assignees

@merlimat merlimat

Labels
area/build doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
8 participants
@merlimat @mattisonchao @eolivelli @hezhangjian @nicoloboschi @liangyuanpeng @michaeljmarshall @codelipenghui