Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][client] [PIP-165] Auto release client useless connections #16165

Merged
merged 19 commits into from
Jul 28, 2022
Merged

[improve][client] [PIP-165] Auto release client useless connections #16165

merged 19 commits into from
Jul 28, 2022
+1,059 −2

Conversation

poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Jun 21, 2022 •
edited by Anonymitaet
Loading

Fixes #15516

see: [PIP-165] Auto release client useless connections

Master Issue: #15516

Documentation

  • doc-required
  • doc-not-needed
  • doc
  • doc-complete

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jun 21, 2022
@poorbarcode poorbarcode force-pushed the feature/useless_connection_cleanup branch from 5bf9e4b to ea7e987 Compare June 22, 2022 01:19
@gaozhangmin gaozhangmin added this to the 2.11.0 milestone Jun 22, 2022
@poorbarcode
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@poorbarcode
Copy link
Contributor Author

/pulsarbot run-failure-checks

@poorbarcode
Copy link
Contributor Author

poorbarcode commented Jun 23, 2022 •
edited
Loading

@Jason918 @codelipenghui @gaoran10 @Technoboy- @gaozhangmin @congbobo184 could you take a look

gaozhangmin
gaozhangmin requested changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@gaozhangmin gaozhangmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall look good to me, Please correct the javadocs.

@poorbarcode
Copy link
Contributor Author

Overall look good to me, Please correct the javadocs.

Thanks for helping to correct it.

@poorbarcode poorbarcode requested a review from gaozhangmin June 24, 2022 05:20
@poorbarcode poorbarcode requested a review from gaozhangmin June 28, 2022 05:09
@poorbarcode poorbarcode reopened this Jun 30, 2022
@poorbarcode poorbarcode force-pushed the feature/useless_connection_cleanup branch from 517f38b to df4da85 Compare June 30, 2022 04:23
@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@poorbarcode
fix comment, set checkIntervalSeconds at least 60

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
45bd3c1
@poorbarcode
fix comment: scheduleAtFixedRate --> scheduleWithFixedDelay
bfc6de8
@poorbarcode poorbarcode requested a review from Technoboy- July 27, 2022 08:31
@poorbarcode
Copy link
Contributor Author

poorbarcode commented Jul 27, 2022 •
edited
Loading

@codelipenghui @Technoboy- @AlphaWang @congbobo184 @gaozhangmin I extract a new class ClientCnxIdleStateManager to make ClientCnx more simple, could you review this PR again?

mattisonchao
mattisonchao approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@mattisonchao mattisonchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some questions, I hope you can answer them.

@mattisonchao
Copy link
Member

@AlphaWang Please review again.

@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@poorbarcode
Copy link
Contributor Author

@codelipenghui @Technoboy- @AlphaWang @congbobo184 @gaozhangmin I extract a new class ClientCnxIdleState to make ClientCnx more simple, could you review this PR again?

@Technoboy- Technoboy- merged commit 89b6a53 into apache:master Jul 28, 2022
Gleiphir2769 pushed a commit to Gleiphir2769/pulsar that referenced this pull request Aug 4, 2022
@poorbarcode @Gleiphir2769
[improve][client] [PIP-165] Auto release client useless connections (a…
aed745a 
…pache#16165)
@poorbarcode poorbarcode mentioned this pull request Aug 11, 2022
Closed
4 tasks
@poorbarcode poorbarcode deleted the feature/useless_connection_cleanup branch September 17, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaozhangmin gaozhangmin

@AlphaWang AlphaWang

@Technoboy- Technoboy-

@codelipenghui codelipenghui

@congbobo184 congbobo184

@eolivelli eolivelli

@lhotari lhotari

@michaeljmarshall michaeljmarshall

@315157973 315157973

@Jason918 Jason918

@mattisonchao mattisonchao

Assignees

@poorbarcode poorbarcode

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

[PIP-165] Auto release client useless connections
7 participants
@poorbarcode @codelipenghui @mattisonchao @AlphaWang @Technoboy- @gaozhangmin @congbobo184