[improve][broker] Optimise msgOutCounter and bytesOutCounter (#16214) #16286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…16214) ### Motivation AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter both generate full stats only to pick the single required counter for the getters. These can be optimised to perform only the necessary work to calculate the counters. ### Modification Provided a scoped implementation of the above methods for the single counter required for each getter.
nahguam
force-pushed
the
topic-out-counters
branch
from
0a1afed to
e237170
Compare
codelipenghui
approved these changes
Jun 29, 2022
codelipenghui
added
type/enhancement
RobertIndie
approved these changes
Jun 30, 2022
|
/pulsarbot run-failure-checks |
|
/pulsarbot run "Unit-BROKER_FLAKY Tests" |
|
Hi, @nahguam It looks like this pull request has many conflicts at branch-2.9 could you please help push a new PR to branch 2.9? |
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Jul 5, 2022
…16214) (apache#16286) ### Motivation AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter both generate full stats only to pick the single required counter for the getters. These can be optimised to perform only the necessary work to calculate the counters. ### Modification Provided a scoped implementation of the above methods for the single counter required for each getter.
codelipenghui
pushed a commit
that referenced
this pull request
Jul 10, 2022
…#16286) AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter both generate full stats only to pick the single required counter for the getters. These can be optimised to perform only the necessary work to calculate the counters. Provided a scoped implementation of the above methods for the single counter required for each getter. (cherry picked from commit 07c46fe)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 11, 2022
…16214) (apache#16286) AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter both generate full stats only to pick the single required counter for the getters. These can be optimised to perform only the necessary work to calculate the counters. Provided a scoped implementation of the above methods for the single counter required for each getter. (cherry picked from commit 07c46fe) (cherry picked from commit 63a3762)
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
…16214) (apache#16286) ### Motivation AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter both generate full stats only to pick the single required counter for the getters. These can be optimised to perform only the necessary work to calculate the counters. ### Modification Provided a scoped implementation of the above methods for the single counter required for each getter.
nahguam
pushed a commit
to nahguam/pulsar
that referenced
this pull request
Jul 25, 2022
…16214) (apache#16286) AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter both generate full stats only to pick the single required counter for the getters. These can be optimised to perform only the necessary work to calculate the counters. Provided a scoped implementation of the above methods for the single counter required for each getter. (cherry picked from commit 07c46fe)
nahguam
pushed a commit
to nahguam/pulsar
that referenced
this pull request
Aug 4, 2022
…16214) (apache#16286) AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter both generate full stats only to pick the single required counter for the getters. These can be optimised to perform only the necessary work to calculate the counters. Provided a scoped implementation of the above methods for the single counter required for each getter. (cherry picked from commit 07c46fe)
|
#16771 cherry-picked this improvement., I remove the release 2.9.4 label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter
both generate full stats only to pick the single required counter for
the getters. These can be optimised to perform only the necessary work
to calculate the counters.
Modification
Provided a scoped implementation of the above methods for the single
counter required for each getter.
Fixes #16214
Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
Implementation optimisation only
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)