Retry on failure of Unloading-namespace bundle #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
2 similar comments
|
CLA is valid! |
|
CLA is valid! |
rdhabalia
force-pushed
the
bundle_unload
branch
from
d8c526e
to
d0300cc
Compare
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Mar 21, 2023
michaeljmarshall
pushed a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Apr 4, 2024
(cherry picked from commit 62f86e9) Conflicts: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/LookupProxyHandler.java pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Broker may fail while unloading namespace bundle and it forever keeps bundle in invalid state as disabled, and it will not remove ownership of the bundle and also not serve new topics. So, unloading should be retried and make sure that bundle gets unloaded successfully.
Modifications
Retry on failure of bundle unloading and make sure to remove ownership of bundle so, bundle can be again owned and served.
Result
Bundle will not be in invalid state if bundle-unloading fails.