Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][cli] Pulsar shell: include pulsar-shell in released tarballs - part 2 #16332

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

nicoloboschi
Copy link
Contributor

Master Issue: #16250

Motivation

See master issue under "Distribution" section.

Changes

New tarball pulsar-shell under distribution directory. It generates a tarball with:

  • pulsar-client-tools dependency (and transitive)

  • log dependencies

  • README + NOTICE as other packages

  • bin/pulsar-shell and bin/pulsar-admin-common.sh scripts

  • conf/client.conf for default configuration

  • doc-required

@nicoloboschi nicoloboschi changed the title [improve][cli] Pulsar shell: include pulsar-shell in released tarballs [improve][cli] Pulsar shell: include pulsar-shell in released tarballs - part 4 Jul 1, 2022
@nicoloboschi nicoloboschi mentioned this pull request Jul 1, 2022
6 tasks
@Anonymitaet Anonymitaet added the doc-required Your PR changes impact docs and you will update later. label Jul 4, 2022
@nicoloboschi nicoloboschi changed the title [improve][cli] Pulsar shell: include pulsar-shell in released tarballs - part 4 [improve][cli] Pulsar shell: include pulsar-shell in released tarballs - part 2 Jul 14, 2022
@nicoloboschi nicoloboschi marked this pull request as ready for review July 14, 2022 12:18
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicoloboschi nicoloboschi merged commit fab2b3f into apache:master Jul 15, 2022
@nicoloboschi nicoloboschi added this to the 2.11.0 milestone Jul 15, 2022
@momo-jun
Copy link
Contributor

Hi, @nicoloboschi, will you add or update relevant docs in a follow-up PR?

@Anonymitaet Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-complete Your PR changes impact docs and the related docs have been already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants