Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][workflow] Cancel duplicate docbot workflows #16368

Merged

Conversation

maxsxu
Copy link
Contributor

@maxsxu maxsxu commented Jul 4, 2022

Master Issue: #15797

Motivation

Cancel duplicate docbot workflows.

Modifications

Add docbot ci to cancel workflow.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Signed-off-by: Max Xu <maxs.xu@gmail.com>
@Anonymitaet
Copy link
Member

@urfreespace
Could you please review this PR from a technical perspective?
Thank you! 😊

@Anonymitaet
Copy link
Member

/pulsarbot run-failure-checks

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

@maxsxu Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jul 5, 2022
@Anonymitaet Anonymitaet merged commit 315d68a into apache:master Jul 5, 2022
@Anonymitaet
Copy link
Member

FYI @SignorMercurio

Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Jul 5, 2022
@maxsxu maxsxu deleted the fix/docbot-cancel-duplicate-workflows branch July 5, 2022 14:49
@nicoloboschi
Copy link
Contributor

@maxsxu it looks like after this commit there are pull requests blocked by this workflow. The workflow never finishes and it gets cancelled

Some examples:

@maxsxu
Copy link
Contributor Author

maxsxu commented Jul 7, 2022

@maxsxu it looks like after this commit there are pull requests blocked by this workflow. The workflow never finishes and it gets cancelled

Some examples:

Thanks for reporting this.
Fixed by #16437

wuxuanqicn pushed a commit to wuxuanqicn/pulsar that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants