[Branch-2.7][Cherry-pick] Fix the reader skips compacted data which original ledger been removed. #16407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #12522
Motivation
The compactor update the compaction cursor(mark delete) first and then update the
compactionHorizon
of the compacted topic. During the compaction cursor move forward, the original ledger will be removed if no other durable cursors. At the same time, if the reader is reading data from the original ledger, the reader will skip the data while the original ledger been removed, details to see #6787. So the reader might skip the compacted data since thecompactionHorizon
have not updated yet.The approach is:
compactionHorizon
before the compaction cursor move forward,so that the reader will not skip the original data before
compactionHorizon
updated.If the broker crashes before the new compacted Ledger ID been persistent,
after the topic been loaded, the compaction can be trigger again and will not loss any data,
but we will have an orphan ledger cannot be delete in the BookKeeper cluster.