Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][flaky-test] PersistentFailoverE2ETest.testSimpleConsumerEventsWithPartition #16493

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

codelipenghui
Copy link
Contributor

@codelipenghui codelipenghui commented Jul 9, 2022

Fixes #6014 #16532

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@codelipenghui codelipenghui self-assigned this Jul 9, 2022
@codelipenghui codelipenghui added this to the 2.11.0 milestone Jul 9, 2022
@codelipenghui codelipenghui marked this pull request as ready for review July 9, 2022 10:44
@github-actions
Copy link

github-actions bot commented Jul 9, 2022

@codelipenghui Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jul 9, 2022
@codelipenghui codelipenghui merged commit 8a54fd9 into apache:master Jul 12, 2022
@codelipenghui codelipenghui deleted the penghui/fix-6014 branch July 12, 2022 16:30
wuxuanqicn pushed a commit to wuxuanqicn/pulsar that referenced this pull request Jul 14, 2022
codelipenghui added a commit that referenced this pull request Jul 15, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jul 19, 2022
…ithPartition (apache#16493)

(cherry picked from commit 8a54fd9)
(cherry picked from commit 3fc367d)
congbobo184 pushed a commit that referenced this pull request Nov 8, 2022
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Nov 8, 2022
congbobo184 pushed a commit that referenced this pull request Nov 30, 2022
@BewareMyPower
Copy link
Contributor

It's still flaky, while it now sometimes failed at

        verifyConsumerActive(listener1, -1);
java.lang.AssertionError: 
Expected :null
Actual   :-1
<Click to see difference>

	at org.apache.pulsar.broker.service.PersistentFailoverE2ETest.verifyConsumerActive(PersistentFailoverE2ETest.java:110)
	at org.apache.pulsar.broker.service.PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition(PersistentFailoverE2ETest.java:156)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky-test: PersistentFailoverE2ETest.testSimpleConsumerEventsWithPartition
9 participants