-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Pulsar txn metrics to specify OpenMetrics #16581
Conversation
@Shoothzj Please provide a correct documentation label for your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change. If we really want to go with this path we should keep both the versions, deprecate the older ones and eventually remove them in a future version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@nicoloboschi - you are correct that this is a breaking change. @Shoothzj proposed this change on the mailing list: https://lists.apache.org/thread/ojwn2l2rtp4lyyrjbhmnf0m6cprjfwx8. The thread mentions that upgrading the prometheus client depends up fixing counters that do not end with _total
. We have already merged #13785. I don't think we can easily make it work to expose both metrics, so as long as we communicate to our users, I think this is okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michaeljmarshall for pointing the ML discussion.
I agree that sooner or later we have to move to newer versions of Prometheus and it's better to rename all the needed metrics in the same release
@nicoloboschi I will follow up on this. Ensure all the metrics to be renamed before 2.11.0 |
2e6622e
to
734a8af
Compare
734a8af
to
10c9c16
Compare
/pulsarbot run-failure-checks |
Motivation
See https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md
A COUNTER needs
metrics_name_total
ormetrics_name_created
This PR contains metric name broken changes.
Modifications
Rename counter's
_count
to_total
metrics name broken changes
pulsar_txn_committed_count
topulsar_txn_committed_total
pulsar_txn_aborted_count
topulsar_txn_aborted_total
pulsar_txn_created_count
topulsar_txn_created_total
pulsar_txn_timeout_count
topulsar_txn_timeout_total
pulsar_txn_append_log_count
topulsar_txn_append_log_total
Documentation
doc
As mentioned above, the metrics name has changed