Rename Pulsar schema metrics to specify OpenMetrics #16610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
nicoloboschi
approved these changes
Jul 15, 2022
hezhangjian
pushed a commit
to apache/bookkeeper
that referenced
this pull request
Jul 16, 2022
### Motivation See https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md A COUNTER needs `metrics_name_total` or `metrics_name_created` This PR contains metric name broken changes. ### Modifications Rename counter's `_count` to `_total` ### metrics name broken changes - rename `FAILED_TO_RESOLVE_NETWORK_LOCATION_COUNTER` to `FAILED_TO_RESOLVE_NETWORK_LOCATION_TOTAL` - rename `ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNT` to `ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_TOTAL` - rename `ACTIVE_ENTRY_LOG_COUNT` to `ACTIVE_ENTRY_LOG_TOTAL` - rename `MAJOR_COMPACTION_COUNT` to `MAJOR_COMPACTION_TOTAL` - rename `MINOR_COMPACTION_COUNT` to `MINOR_COMPACTION_TOTAL` - rename `ACTIVE_LEDGER_COUNT` to `ACTIVE_LEDGER_TOTAL` - rename `DELETED_LEDGER_COUNT` to `DELETED_LEDGER_TOTAL` - rename `JOURNAL_FORCE_WRITE_GROUPING_COUNT` to `JOURNAL_FORCE_WRITE_GROUPING_TOTAL` ### Also see - apache/pulsar#13785 - apache/pulsar#16591 - apache/pulsar#16610 - apache/pulsar#16611
|
/pulsarbot run-failure-checks |
codelipenghui
added
release/important-notice
codelipenghui
approved these changes
Jul 16, 2022
4 tasks
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation See https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md A COUNTER needs `metrics_name_total` or `metrics_name_created` This PR contains metric name broken changes. ### Modifications Rename counter's `_count` to `_total` ### metrics name broken changes - rename `FAILED_TO_RESOLVE_NETWORK_LOCATION_COUNTER` to `FAILED_TO_RESOLVE_NETWORK_LOCATION_TOTAL` - rename `ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_COUNT` to `ENSEMBLE_NOT_ADHERING_TO_PLACEMENT_POLICY_TOTAL` - rename `ACTIVE_ENTRY_LOG_COUNT` to `ACTIVE_ENTRY_LOG_TOTAL` - rename `MAJOR_COMPACTION_COUNT` to `MAJOR_COMPACTION_TOTAL` - rename `MINOR_COMPACTION_COUNT` to `MINOR_COMPACTION_TOTAL` - rename `ACTIVE_LEDGER_COUNT` to `ACTIVE_LEDGER_TOTAL` - rename `DELETED_LEDGER_COUNT` to `DELETED_LEDGER_TOTAL` - rename `JOURNAL_FORCE_WRITE_GROUPING_COUNT` to `JOURNAL_FORCE_WRITE_GROUPING_TOTAL` ### Also see - apache/pulsar#13785 - apache/pulsar#16591 - apache/pulsar#16610 - apache/pulsar#16611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md
A COUNTER needs
metrics_name_totalormetrics_name_createdThis PR contains metric name broken changes.
Modifications
Rename counter's
_countto_totalmetrics name broken changes
pulsar_schema_del_ops_failed_counttopulsar_schema_del_ops_failed_totalpulsar_schema_get_ops_failed_counttopulsar_schema_get_ops_failed_totalpulsar_schema_put_ops_failed_counttopulsar_schema_put_ops_failed_totalpulsar_schema_compatible_counttopulsar_schema_compatible_totalpulsar_schema_incompatible_counttopulsar_schema_incompatible_totalDocumentation
docAs mentioned above, the metrics name has changed