[Improve][broker] Support clear old bookie data for BKCluster

pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java

@@ -443,6 +443,7 @@ private void startBookieWithRocksDB() throws Exception {
                 .bkPort(bkPort)
                 .numBookies(numOfBk)
                 .dataDir(bkDir)
+                .clearOldData(wipeData)
                 .build();
         config.setBookkeeperNumberOfChannelsPerBookie(1);
         config.setMetadataStoreUrl(metadataStoreUrl);

pulsar-broker/src/test/java/org/apache/pulsar/broker/EmbeddedPulsarCluster.java

@@ -28,6 +28,7 @@
 import org.apache.pulsar.common.policies.data.ClusterData;
 import org.apache.pulsar.common.policies.data.TenantInfo;
 import org.apache.pulsar.metadata.bookkeeper.BKCluster;
+import org.junit.platform.commons.util.StringUtils;
 
 
 public class EmbeddedPulsarCluster implements AutoCloseable {
@@ -52,13 +53,16 @@ public class EmbeddedPulsarCluster implements AutoCloseable {
     private final PulsarAdmin admin;
 
     @Builder
-    private EmbeddedPulsarCluster(int numBrokers, int numBookies, String metadataStoreUrl) throws Exception {
+    private EmbeddedPulsarCluster(int numBrokers, int numBookies, String metadataStoreUrl,
+                                  String dataDir, boolean clearOldData) throws Exception {
         this.numBrokers = numBrokers;
         this.numBookies = numBookies;
         this.metadataStoreUrl = metadataStoreUrl;
         this.bkCluster = BKCluster.builder()
                 .metadataServiceUri(metadataStoreUrl)
                 .numBookies(numBookies)
+                .dataDir(StringUtils.isNotBlank(dataDir) ? dataDir : null)
+                .clearOldData(clearOldData)
                 .build();
 
         for (int i = 0; i < numBrokers; i++) {

pulsar-broker/src/test/java/org/apache/pulsar/broker/EndToEndMetadataTest.java

@@ -19,27 +19,51 @@
 package org.apache.pulsar.broker;
 
 import static org.testng.Assert.assertEquals;
+import java.io.File;
 import java.util.function.Supplier;
 import lombok.Cleanup;
 import lombok.extern.slf4j.Slf4j;
+import org.apache.bookkeeper.util.IOUtils;
+import org.apache.commons.io.FileUtils;
 import org.apache.pulsar.client.api.Consumer;
 import org.apache.pulsar.client.api.Message;
 import org.apache.pulsar.client.api.Producer;
 import org.apache.pulsar.client.api.PulsarClient;
 import org.apache.pulsar.client.api.Schema;
 import org.apache.pulsar.metadata.BaseMetadataStoreTest;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
 @Slf4j
 public class EndToEndMetadataTest extends BaseMetadataStoreTest {
 
+    private File tempDir;
+
+    @BeforeClass(alwaysRun = true)
+    @Override
+    public void setup() throws Exception {
+        super.setup();
+        tempDir = IOUtils.createTempDir("bookies", "test");
+    }
+
+    @AfterClass(alwaysRun = true)
+    @Override
+    public void cleanup() throws Exception {
+        super.cleanup();
+        FileUtils.deleteDirectory(tempDir);
+    }
+
     @Test(dataProvider = "impl")
     public void testPublishConsume(String provider, Supplier<String> urlSupplier) throws Exception {
+
         @Cleanup
         EmbeddedPulsarCluster epc = EmbeddedPulsarCluster.builder()
                 .numBrokers(1)
                 .numBookies(1)
                 .metadataStoreUrl(urlSupplier.get())
+                .dataDir(tempDir.getAbsolutePath())
+                .clearOldData(true)
                 .build();
 
         @Cleanup

pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/BKCluster.java

@@ -18,6 +18,7 @@
  */
 package org.apache.pulsar.metadata.bookkeeper;
 
+import static org.apache.commons.io.FileUtils.cleanDirectory;
 import java.io.File;
 import java.io.IOException;
 import java.net.NetworkInterface;
@@ -75,6 +76,8 @@ public static class BKClusterConf {
         private String dataDir;
         private int bkPort = 0;
 
+        private boolean clearOldData;
+
         public BKClusterConf metadataServiceUri(String metadataServiceUri) {
             this.metadataServiceUri = metadataServiceUri;
             return this;
@@ -95,6 +98,11 @@ public BKClusterConf bkPort(int bkPort) {
             return this;
         }
 
+        public BKClusterConf clearOldData(Boolean clearOldData) {
+            this.clearOldData = clearOldData;
+            return this;
+        }
+
         public BKCluster build() throws Exception {
             return new BKCluster(this);
         }
@@ -198,6 +206,10 @@ private ServerConfiguration newServerConfiguration() throws Exception {
             dataDir = createTempDir("bookie", "test");
         }
 
+        if (clusterConf.clearOldData) {
+            cleanDirectory(dataDir);
+        }
+
         int port;
         if (baseConf.isEnableLocalTransport() || !baseConf.getAllowEphemeralPorts() || clusterConf.bkPort == 0) {
             port = PortManager.nextFreePort();

pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java

@@ -41,14 +41,14 @@ public abstract class BaseMetadataStoreTest extends TestRetrySupport {
 
     @BeforeClass(alwaysRun = true)
     @Override
-    public final void setup() throws Exception {
+    public void setup() throws Exception {
         incrementSetupNumber();
         zks = new TestZKServer();
     }
 
     @AfterClass(alwaysRun = true)
     @Override
-    public final void cleanup() throws Exception {
+    public void cleanup() throws Exception {
         markCurrentSetupNumberCleaned();
         if (zks != null) {
             zks.close();