[fix][flaky-test]Fix flaky test in PulsarSinkE2ETest.testPulsarSinkDLQ #16799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
requested changes
Jul 27, 2022
| @@ -189,6 +189,11 @@ public void testPulsarSinkDLQ() throws Exception { | |||
| remainingMessagesToReceive.add(messageBody); | |||
| } | |||
|
|
|||
| // Wait all msg show in dlqTopic. | |||
| Awaitility.await().untilAsserted(()-> { | |||
| assertEquals(admin.topics().getLastMessageId(dlqTopic).toString(),"10:1:-1:8"); | |||
There was a problem hiding this comment.
Can we guarantee that the message-id is the same for every testing? There is an exception in this PR:https://github.com/apache/pulsar/runs/7524494144?check_suite_focus=true#step:10:1231
We can directly modify the wait time for the consumer to receive the message:
https://github.com/apache/pulsar/pull/16799/files#diff-1be1a68c630a114a3f7770115053f58066cbf117b24d0e73903f6340f7aef793L194
And I think the root cause may not be the timeout setting. 10 seconds should be enough.
There was a problem hiding this comment.
Can we guarantee that the message-id is the same for every testing? There is an exception in this
seems that you are right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16578
Motivation
Fix flaky test in PulsarSinkE2ETest.testPulsarSinkDLQ which sometime run failed , because the msg not show in dlqTopic.
Modifications
Documentation
doc-not-needed(Please explain why)