[Broker] Expose topic level storage write and read rate metrics #16855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
type/enhancement
michaeljmarshall
added
doc-not-needed
michaeljmarshall
added a commit
that referenced
this pull request
Jul 28, 2022
### Motivation We collect metrics on storage read/write rate, but we do not expose it at the topic level. We already expose it at the namespace level. ### Modifications * Expose `pulsar_storage_read_rate` and `pulsar_storage_write_rate` in topic level metrics ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: This change adds two new metrics. ### Documentation - [x] `doc-not-needed` These two metrics are already documented for topic level stats: https://pulsar.apache.org/docs/next/reference-metrics. (cherry picked from commit 23b52e4)
michaeljmarshall
added a commit
that referenced
this pull request
Jul 28, 2022
### Motivation We collect metrics on storage read/write rate, but we do not expose it at the topic level. We already expose it at the namespace level. ### Modifications * Expose `pulsar_storage_read_rate` and `pulsar_storage_write_rate` in topic level metrics ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: This change adds two new metrics. ### Documentation - [x] `doc-not-needed` These two metrics are already documented for topic level stats: https://pulsar.apache.org/docs/next/reference-metrics. (cherry picked from commit 23b52e4)
michaeljmarshall
added a commit
that referenced
this pull request
Jul 28, 2022
### Motivation We collect metrics on storage read/write rate, but we do not expose it at the topic level. We already expose it at the namespace level. ### Modifications * Expose `pulsar_storage_read_rate` and `pulsar_storage_write_rate` in topic level metrics ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: This change adds two new metrics. ### Documentation - [x] `doc-not-needed` These two metrics are already documented for topic level stats: https://pulsar.apache.org/docs/next/reference-metrics. (cherry picked from commit 23b52e4)
michaeljmarshall
added
cherry-picked/branch-2.8
michaeljmarshall
added a commit
to datastax/pulsar
that referenced
this pull request
Jul 28, 2022
…he#16855) ### Motivation We collect metrics on storage read/write rate, but we do not expose it at the topic level. We already expose it at the namespace level. ### Modifications * Expose `pulsar_storage_read_rate` and `pulsar_storage_write_rate` in topic level metrics ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: This change adds two new metrics. ### Documentation - [x] `doc-not-needed` These two metrics are already documented for topic level stats: https://pulsar.apache.org/docs/next/reference-metrics. (cherry picked from commit 23b52e4)
michaeljmarshall
added a commit
to datastax/pulsar
that referenced
this pull request
Jul 28, 2022
…he#16855) ### Motivation We collect metrics on storage read/write rate, but we do not expose it at the topic level. We already expose it at the namespace level. ### Modifications * Expose `pulsar_storage_read_rate` and `pulsar_storage_write_rate` in topic level metrics ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: This change adds two new metrics. ### Documentation - [x] `doc-not-needed` These two metrics are already documented for topic level stats: https://pulsar.apache.org/docs/next/reference-metrics. (cherry picked from commit 23b52e4)
Gleiphir2769
pushed a commit
to Gleiphir2769/pulsar
that referenced
this pull request
Aug 4, 2022
…he#16855) ### Motivation We collect metrics on storage read/write rate, but we do not expose it at the topic level. We already expose it at the namespace level. ### Modifications * Expose `pulsar_storage_read_rate` and `pulsar_storage_write_rate` in topic level metrics ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: This change adds two new metrics. ### Documentation - [x] `doc-not-needed` These two metrics are already documented for topic level stats: https://pulsar.apache.org/docs/next/reference-metrics.
dragonls
pushed a commit
to dragonls/pulsar
that referenced
this pull request
Oct 21, 2022
…he#16855) ### Motivation We collect metrics on storage read/write rate, but we do not expose it at the topic level. We already expose it at the namespace level. ### Modifications * Expose `pulsar_storage_read_rate` and `pulsar_storage_write_rate` in topic level metrics ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: This change adds two new metrics. ### Documentation - [x] `doc-not-needed` These two metrics are already documented for topic level stats: https://pulsar.apache.org/docs/next/reference-metrics. (cherry picked from commit 23b52e4)
dragonls
pushed a commit
to dragonls/pulsar
that referenced
this pull request
Oct 21, 2022
…rge request !49) [Broker] Expose topic level storage write and read rate metrics (apache#16855)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We collect metrics on storage read/write rate, but we do not expose it at the topic level. We already expose it at the namespace level.
Modifications
pulsar_storage_read_rateandpulsar_storage_write_ratein topic level metricsVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
This change adds two new metrics.
Documentation
doc-not-neededThese two metrics are already documented for topic level stats: https://pulsar.apache.org/docs/next/reference-metrics.