Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Branch-2.7] Fixed deadlock on metadata cache missing while doing checkReplication #16889

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

Jason918
Copy link
Contributor

@Jason918 Jason918 commented Jul 31, 2022

Motivation

The origin PR #12484 is merged into branch 2.7, but reverted in #16882 because Unit test BrokerBookieIsolationTest#testBookieIsilationWithSecondaryGroup fails.

The root cause is that policies and localPolicies are not updated after they are read from async process.

Modifications

  1. Cherry-pick PR [Branch-2.7] Fixed deadlock on metadata cache missing while doing che… #12484
  2. Change optPolicies, optLocalPolicies to policies, localPolicies in
    https://github.com/merlimat/pulsar/blob/f53ddc13d7fb28f4c1bd73b23e7f3d8b7fc35591/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1209

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as BrokerBookieIsolationTest#testBookieIsilationWithSecondaryGroup

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-not-needed
    bug fix.

@Jason918
Copy link
Contributor Author

/pulsarbot run-failure-checks

@Technoboy- Technoboy- merged commit b215bc2 into apache:branch-2.7 Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker release/2.7.5 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants