[fix][flaky-test] ElasticSearchClientTests.testBulkBlocking #16920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
force-pushed
the
fix_issuse_16829
branch
from
2b5b593 to
ea95efe
Compare
coderzc
force-pushed
the
fix_issuse_16829
branch
from
ea95efe to
830b571
Compare
codelipenghui
approved these changes
Aug 8, 2022
Technoboy-
approved these changes
Aug 9, 2022
mattisonchao
approved these changes
Aug 9, 2022
Technoboy-
pushed a commit
that referenced
this pull request
Aug 10, 2022
Technoboy-
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Aug 16, 2022
Jason918
pushed a commit
that referenced
this pull request
Sep 2, 2022
(cherry picked from commit f02679d)
congbobo184
pushed a commit
that referenced
this pull request
Nov 11, 2022
(cherry picked from commit f02679d)
congbobo184
pushed a commit
that referenced
this pull request
Dec 7, 2022
(cherry picked from commit f02679d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16829
Motivation
The root cause is the
ack()function will be multi-threaded concurrent execution, butack++is not an atomic operation.Modifications
Use
LongAdderinstead ofintto ensure the atomicity.Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)