-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][doc] Add more configuration methods for basic authentication #16941
Conversation
@momo-jun Could you help review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nodece Please provide a correct documentation label for your PR. |
320daf8
to
bae686e
Compare
@momo-jun Your request has been fixed. Could you help review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Can you also remove the indention in line110~114?
bae686e
to
4c7188d
Compare
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
4c7188d
to
9facdeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@codelipenghui Thanks for telling me that! |
#16941) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
apache#16941) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Signed-off-by: Zixuan Liu nodeces@gmail.com
Motivation
Add documentation for #16935, #16526 and #15822.
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)