Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][cpp-client] Add python3 to rpm build Dockerfile #16992

Closed
wants to merge 1 commit into from
Closed

[fix][cpp-client] Add python3 to rpm build Dockerfile #16992

wants to merge 1 commit into from

Conversation

yaalsn
Copy link
Contributor

@yaalsn yaalsn commented Aug 8, 2022

Motivation

Since PIP-155, all the python scripts in pulsar had been upgraded to python3, so we need to install python3 into Docker image apachepulsar/pulsar-build:centos-7 to run these scripts.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

More

This PR should be cherry-picked to 2.11 branch and rebuild a image via running pulsar-client-cpp/pkg/rpm/build-docker-image.sh and republish to Dockerhub.

@yaalsn yaalsn closed this Aug 8, 2022
@yaalsn yaalsn reopened this Aug 8, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 8, 2022
@yaalsn yaalsn closed this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant