[fix][broker] Increment topic stats outbound message counters and update rate after messages have been written to the TCP/IP connection #17043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essages have been written to the TCP/IP connection - counters could get off a lot when a large number of consumers are reconnecting
lhotari
requested review from
merlimat,
dlg99,
eolivelli,
codelipenghui,
congbobo184 and
michaeljmarshall
Technoboy-
approved these changes
Aug 11, 2022
codelipenghui
approved these changes
Aug 11, 2022
codelipenghui
added
type/bug
Technoboy-
pushed a commit
that referenced
this pull request
Aug 11, 2022
…essages have been written to the TCP/IP connection (#17043)
coderzc
pushed a commit
to coderzc/pulsar
that referenced
this pull request
Aug 13, 2022
…essages have been written to the TCP/IP connection (apache#17043)
Technoboy-
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Aug 16, 2022
…essages have been written to the TCP/IP connection (apache#17043)
|
Hi @lhotari |
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Sep 5, 2022
…essages have been written to the TCP/IP connection (apache#17043) (cherry picked from commit 2bc933e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Additional context
Pulsar increments the counters when the sending is scheduled. Since the dispatching code is asynchronous, it behaves in a way that Pulsar will try to consume all permits and queue as much of messages as possible. Since the counters are incremented before the messages have been written to the TCP/IP socket, this will result in the counters getting out of sync when the connection is disconnected.
Modifications
doc-not-needed