[cleanup][broker] remove unnecessary parameters(reusefuture) and related logic #17378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonHxy
approved these changes
Aug 31, 2022
|
LGTM |
gaozhangmin
requested changes
Aug 31, 2022
| } | ||
| return FutureUtil.waitForAll(futures); | ||
| } | ||
|
|
||
| private CompletableFuture<Void> tryCreatePartitionAsync(final int partition, CompletableFuture<Void> reuseFuture) { | ||
| CompletableFuture<Void> result = reuseFuture == null ? new CompletableFuture<>() : reuseFuture; |
There was a problem hiding this comment.
I don't suggest we change signature of method for the might extension in the future
There was a problem hiding this comment.
@gaozhangmin
IMHO：
The parameter reusefuture was added for a function in the PR #6478, but it was later removed in the PR #9485, so it is reasonable to restore the parameter to its original state.
There was a problem hiding this comment.
I don't suggest we change signature of method for the might extension in the future
@gaozhangmin
I don't see any necessary to keep this, at least in the near future. Let's make the code cleaner.
|
/pulsarbot run-failure-checks |
Pomelongan
force-pushed
the
opt_logic_of_trycreatepartionasync
branch
from
2d26c83 to
551bd3b
Compare
|
/pulsarbot run-failure-checks |
Jason918
changed the title
Jason918
approved these changes
Sep 4, 2022
Jason918
added
type/cleanup
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
gaozhangmin
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the
org.apache.pulsar.broker.admin.AdminResource#tryCreatePartitionAsyncmethod is called, the value of reusefuture passed in is null, which is a bit redundant and can be directly removedModifications
The input parameter reusefuture and the judgment that the parameter is null are removed
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-needed