[improve][broker][PIP-149]make setPersistence method async in Namespaces #17421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
AnonHxy
reviewed
Sep 3, 2022
| return null; | ||
| }); | ||
| }) | ||
| .thenCompose(__ -> doUpdatePersistenceAsync(null)); |
There was a problem hiding this comment.
doUpdatePersistenceAsync(null) -> doUpdatePersistenceAsync(persistence)
AnonHxy
reviewed
Sep 3, 2022
Comment on lines
1566
to
1571
| .thenCompose(__ -> { | ||
| return CompletableFuture.supplyAsync(() -> { | ||
| validatePersistencePolicies(persistence); | ||
| return null; | ||
| }); | ||
| }) |
There was a problem hiding this comment.
I think we should remove this code block from line1566 to line1571
Pomelongan
force-pushed
the
asyncSetPersistence
branch
from
6a18cc3 to
7a0dd10
Compare
|
/pulsarbot run-failure-checks |
Technoboy-
added
type/enhancement
Technoboy-
approved these changes
Sep 5, 2022
|
Please fix the CI |
Pomelongan
force-pushed
the
asyncSetPersistence
branch
from
7a0dd10 to
ea2a3cd
Compare
|
/pulsarbot run-failure-checks |
|
Please fix the check style issue. |
Pomelongan
force-pushed
the
asyncSetPersistence
branch
from
ea2a3cd to
f28d865
Compare
|
|
/pulsarbot run-failure-checks |
Pomelongan
force-pushed
the
asyncSetPersistence
branch
from
f28d865 to
be247b6
Compare
AnonHxy
approved these changes
Sep 11, 2022
tisonkun
pushed a commit
to tisonkun/pulsar
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #14365
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-needed