[feat][broker][PIP-195] Implement BucketDelayedDeliveryTrackerFactory and load BucketDelayedDeliveryTracker - part6 #17756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pr had no activity for 30 days, mark with Stale label. |
coderzc
changed the title
coderzc
force-pushed
the
bucket_delayed_factory
branch
from
bd6d356 to
95c2203
Compare
coderzc
changed the title
coderzc
added
type/feature
| import org.testng.annotations.AfterClass; | ||
| import org.testng.annotations.BeforeClass; | ||
|
|
||
| public class BucketDelayedDeliveryTest extends DelayedDeliveryTest { |
There was a problem hiding this comment.
Please add the test group.
And if we don't have any test method for this class. Will the before-class and after-class be executed?
There was a problem hiding this comment.
And if we don't have any test method for this class. Will the before-class and after-class be executed?
Yes, they can be executed.
|
The test failed and wait for #19124 merged. |
codelipenghui
approved these changes
Jan 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #17756 +/- ##
============================================
- Coverage 47.73% 47.15% -0.58%
+ Complexity 10819 10695 -124
============================================
Files 712 713 +1
Lines 69645 69672 +27
Branches 7481 7482 +1
============================================
- Hits 33242 32857 -385
- Misses 32699 33100 +401
- Partials 3704 3715 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #16763
Motivation
#16763
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: coderzc#34