Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][ci] succeed only if all needs pass #17923

Closed
wants to merge 1 commit into from

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Oct 4, 2022

This OR logic has been introduced by #17614.

I don't know why it's added in the first place - we shouldn't have an OR here. But anyway since pulsar-client-cpp moved out, it should be reasonable to fix the workflow.

Otherwise, if system tests passed but other tests failed or canceled, the required status can still pass.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository: tisonkun#5

This OR logic has been introduced by apache#17614.

I don't know why it's added in the first place - we shouldn't have a OR here. But anyway since pulsar-client-cpp moved out, it should be reasonable to fix the workflow.
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 4, 2022
@tisonkun
Copy link
Member Author

tisonkun commented Oct 4, 2022

cc @lhotari @nicoloboschi

@lhotari
Copy link
Member

lhotari commented Oct 4, 2022

I don't know why it's added in the first place - we shouldn't have an OR here. But anyway since pulsar-client-cpp moved out, it should be reasonable to fix the workflow.

The point of it was that when cpp build still existed, and there was a cpp only change, the unit & integration tests would have been skipped. the logic was for that purpose. The problem was that it wasn't properly removed in #17881 .

@tisonkun tisonkun deleted the patch-4 branch October 9, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants