Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.9][fix][storage]fix OpAddEntry release error when exception in ManagedLedgerInterceptor #17929

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

HQebupt
Copy link
Contributor

@HQebupt HQebupt commented Oct 4, 2022

Motivation

This PR is fully based on #17394.

Modifications

  • Remove duplicate release in ManagedLedgerInterceptor

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-not-needed

@HQebupt
Copy link
Contributor Author

HQebupt commented Oct 4, 2022

@mattisonchao PTAL

@HQebupt HQebupt requested a review from mattisonchao October 18, 2022 03:52
@congbobo184 congbobo184 merged commit e6364bc into apache:branch-2.9 Nov 14, 2022
@congbobo184 congbobo184 added release/2.9.4 cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs labels Nov 14, 2022
congbobo184 pushed a commit that referenced this pull request Dec 7, 2022
…edgerInterceptor (#17929)

This PR is fully based on #17394.

- Remove duplicate release in `ManagedLedgerInterceptor`

(cherry picked from commit e6364bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.9.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants