-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][schema] Change update schema auth from tenant to produce #18074
[improve][schema] Change update schema auth from tenant to produce #18074
Conversation
assertThrows(PulsarAdminException.class, () -> adminWithoutPermission.schemas().createSchema(topicName, si)); | ||
adminWithAdminPermission.schemas().createSchema(topicName, si); | ||
assertThrows(PulsarAdminException.class, () -> adminWithConsumePermission.schemas().getSchemaInfo(topicName)); | ||
adminWithProducePermission.schemas().createSchema(topicName, si); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the old test, and then append a new test.
}); | ||
}); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this reusable, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
This PR also should sync to branch-2.9 and branch-2.10. |
Codecov Report
@@ Coverage Diff @@
## master #18074 +/- ##
=============================================
+ Coverage 34.91% 52.47% +17.56%
- Complexity 5707 7284 +1577
=============================================
Files 607 393 -214
Lines 53396 43419 -9977
Branches 5712 4465 -1247
=============================================
+ Hits 18644 22786 +4142
+ Misses 32119 18139 -13980
+ Partials 2633 2494 -139
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@congbobo184 Could you please help cherry-pick this PR to branch-2.10 and branch-2.9? It will help users who want to create topics by Admin API, but the tenant admin is required before upgrading to 2.11.0. |
…pache#18074) (cherry picked from commit 26b47ff) (cherry picked from commit 3b9f854)
…pache#18074) (cherry picked from commit 26b47ff) (cherry picked from commit 3b9f854)
discuss: https://lists.apache.org/thread/0ts6josxxq4gt3qw2toxf9jd77d7s6kj
Motivation
Now, we have two authentications for updating the schema
produce or consume when open autoUpdateSchema
This will produce problems when using different authentications to
update the schema.
Modification
Documentation
doc-not-needed
Matching PR in the forked repository
PR in forked repository: