-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][fn] fix function failed to start if no typeClassName
provided in FunctionDetails
#18111
Merged
codelipenghui
merged 4 commits into
apache:master
from
freeznet:freeznet/allow-get-function-types-in-runtime
Nov 11, 2022
Merged
[fix][fn] fix function failed to start if no typeClassName
provided in FunctionDetails
#18111
codelipenghui
merged 4 commits into
apache:master
from
freeznet:freeznet/allow-get-function-types-in-runtime
Nov 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeznet
force-pushed
the
freeznet/allow-get-function-types-in-runtime
branch
from
October 20, 2022 02:52
b1510fc
to
054e9ae
Compare
Codecov Report
@@ Coverage Diff @@
## master #18111 +/- ##
=============================================
+ Coverage 34.91% 45.85% +10.94%
- Complexity 5707 17614 +11907
=============================================
Files 607 1574 +967
Lines 53396 128526 +75130
Branches 5712 14149 +8437
=============================================
+ Hits 18644 58939 +40295
- Misses 32119 63478 +31359
- Partials 2633 6109 +3476
Flags with carried forward coverage won't be shown. Click here to find out more.
|
freeznet
added
area/function
type/bug
The PR fixed a bug or issue reported a bug
labels
Oct 21, 2022
nlu90
approved these changes
Nov 8, 2022
codelipenghui
approved these changes
Nov 11, 2022
codelipenghui
added
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
cherry-picked/branch-2.11
labels
Nov 11, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 23, 2022
… in `FunctionDetails` (apache#18111) (cherry picked from commit 8ad7157) (cherry picked from commit b873464)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/function
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
cherry-picked/branch-2.11
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.9.4
release/2.10.3
release/2.11.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #18110
Motivation
When user run pulsar functions directly without
pulsar-admin functions create
orpulsar-admin functions localrun
, it requires to providetypeClassName
infunctionDetails
, otherwise the function will failed to start.Modifications
try to inferring the
typeClassName
at runtime for Function, Sink and Source.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: freeznet#8