[fix] [pulsar-client] Fix pendingLookupRequestSemaphore leak when Ser…

[hezhangjian]

Motivation

pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java

Lines 748 to 774 in b061c6a

	protected void handleError(CommandError error) {
	checkArgument(state == State.SentConnectFrame || state == State.Ready);
	log.warn("{} Received error from server: {}", ctx.channel(), error.getMessage());
	long requestId = error.getRequestId();
	if (error.getError() == ServerError.ProducerBlockedQuotaExceededError) {
	log.warn("{} Producer creation has been blocked because backlog quota exceeded for producer topic",
	ctx.channel());
	}
	if (error.getError() == ServerError.AuthenticationError) {
	connectionFuture.completeExceptionally(
	new PulsarClientException.AuthenticationException(error.getMessage()));
	log.error("{} Failed to authenticate the client", ctx.channel());
	}
	if (error.getError() == ServerError.NotAllowedError) {
	log.error("Get not allowed error, {}", error.getMessage());
	connectionFuture.completeExceptionally(new PulsarClientException.NotAllowedException(error.getMessage()));
	}
	CompletableFuture<?> requestFuture = pendingRequests.remove(requestId);
	if (requestFuture != null) {
	requestFuture.completeExceptionally(
	getPulsarClientException(error.getError(),
	buildError(error.getRequestId(), error.getMessage())));
	} else {
	log.warn("{} Received unknown request id from server: {}", ctx.channel(), error.getRequestId());
	}
	}

The pendingLookupRequestSemaphore will leak when handleError. There are LookUpRequestSemaphore not released when removing it from pendingRequests

related PR: #17856

Modifications

We can't easily release the semaphore in handleError, because there are not only LookUpRequest. So release the semaphore when LookupException

Verifying this change

Add unit test case to cover this change

Documentation

• doc-required
  (Your PR needs to update docs and you will update later)

• doc-not-needed
  bug fixs, no need doc

• doc
  (Your PR contains doc changes)

• doc-complete
  (Docs have been already added)

[codecov-commenter]

Codecov Report

Merging #18219 (9559b78) into master (6c65ca0) will increase coverage by 14.78%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #18219       +/-   ##
=============================================
+ Coverage     34.91%   49.70%   +14.78%     
- Complexity     5707     6991     +1284     
=============================================
  Files           607      398      -209     
  Lines         53396    43548     -9848     
  Branches       5712     4474     -1238     
=============================================
+ Hits          18644    21646     +3002     
+ Misses        32119    19527    -12592     
+ Partials       2633     2375      -258     

Flag	Coverage Δ
unittests	49.70% <0.00%> (+14.78%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...in/java/org/apache/pulsar/PulsarBrokerStarter.java	0.00% <ø> (ø)
.../org/apache/pulsar/PulsarClusterMetadataSetup.java	0.00% <ø> (ø)
...g/apache/pulsar/PulsarClusterMetadataTeardown.java	0.00% <ø> (ø)
...org/apache/pulsar/PulsarInitialNamespaceSetup.java	0.00% <ø> (ø)
.../main/java/org/apache/pulsar/PulsarStandalone.java	0.00% <0.00%> (ø)
...ava/org/apache/pulsar/PulsarStandaloneBuilder.java	0.00% <ø> (ø)
...apache/pulsar/broker/service/TopicListService.java	10.65% <0.00%> (-44.27%)	⬇️
...ce/schema/validator/StructSchemaDataValidator.java	52.38% <0.00%> (-9.53%)	⬇️
...g/apache/pulsar/broker/service/StreamingStats.java	75.67% <0.00%> (-8.11%)	⬇️
...tent/NonPersistentDispatcherMultipleConsumers.java	40.74% <0.00%> (-7.41%)	⬇️
... and 388 more

[hezhangjian]

/pulsarbot run-failure-checks