[fix][broker] Fix the wrong behaviour when set overrideBrokerNicSpeedGbps
#18818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattisonchao Please add the following content to your PR description and select a checkbox: |
github-actions
bot
added
doc-not-needed
2 tasks
mattisonchao
requested review from
lhotari,
codelipenghui,
eolivelli and
Technoboy-
mattisonchao
added
release/blocker
Technoboy-
reviewed
Dec 8, 2022
...-broker/src/test/java/org/apache/pulsar/broker/loadbalance/LinuxBrokerHostUsageImplTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #18818 +/- ##
============================================
- Coverage 50.05% 47.02% -3.04%
+ Complexity 11024 10533 -491
============================================
Files 703 703
Lines 68814 68817 +3
Branches 7378 7377 -1
============================================
- Hits 34446 32359 -2087
- Misses 30621 32818 +2197
+ Partials 3747 3640 -107
Flags with carried forward coverage won't be shown. Click here to find out more.
|
congbobo184
approved these changes
Dec 8, 2022
| @@ -121,10 +122,12 @@ public void calculateBrokerHostUsage() { | |||
| this.usage = usage; | |||
| } | |||
|
|
|||
| private double getTotalNicLimitWithConfiguration(List<String> nics) { | |||
| @VisibleForTesting | |||
| public double getTotalNicLimitWithConfiguration(List<String> nics) { | |||
There was a problem hiding this comment.
it's a public method, so can delete @VisibleForTesting
coderzc
approved these changes
Dec 8, 2022
Technoboy-
pushed a commit
that referenced
this pull request
Dec 8, 2022
Technoboy-
added
cherry-picked/branch-2.11
and removed
release/blocker
2 tasks
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 26, 2022
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 29, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This break was introduced by #14648 and affected unreleased 2.11.
Modifications
overrideBrokerNicSpeedGbpswith the NIC number.Verifying this change
Make sure that the change passes the CI checks.
doc-not-needed