Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][branch-2.10]upgrade the bookkeeper version to 4.14.7 #19179

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

horizonzy
Copy link
Member

@horizonzy horizonzy commented Jan 11, 2023

Fixes #xyz

Master Issue: #xyz

PIP: #xyz

Motivation

Motivation

BookKeeper 4.14.7 has been released and it contains a lot of notable bug fixes. We need to upgrade the BookKeeper dependency from 4.14.5 to 4.14.7.

BookKeeper release notes can be found:
https://github.com/apache/bookkeeper/releases

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions
Copy link

@horizonzy Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jan 11, 2023
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should update the license file as well

Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold on to the upgrade due to the RocksDB issue. apache/bookkeeper#3734

@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Feb 13, 2023
@horizonzy horizonzy closed this Feb 13, 2023
@hangc0276
Copy link
Contributor

BookKeeper 4.14.7 has been released, we can use BookKeeper 4.14.7 directly.

@hangc0276 hangc0276 reopened this Feb 20, 2023
@hangc0276 hangc0276 changed the title [improve][branch-2.10]upgrade the bookkeeper version to 4.14.6 [improve][branch-2.10]upgrade the bookkeeper version to 4.14.7 Feb 21, 2023
@github-actions github-actions bot removed the Stale label Feb 21, 2023
@liangyepianzhou
Copy link
Contributor

@horizonzy The OWASP check was failed. Could you please merge branch-2.10 to fix it?

@hangc0276
Copy link
Contributor

@horizonzy The OWASP check was failed. Could you please merge branch-2.10 to fix it?

@liangyepianzhou If the master has resolved the OWASP check, I think we can merge this PR directly. Because the CI need to rerun a few times before getting passed.

@Technoboy- Technoboy- merged commit 96e3f39 into apache:branch-2.10 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants