[improve][cli] pulsar-perf: refactor to reduce code duplication #19279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Jan 31, 2023
|
closing and re-opening to run CI with latest changes from master. |
pgier
force-pushed
the
pulsar-perf-cli-refactor
branch
from
3f01ce1 to
6fb9cc8
Compare
|
Rebased on latest master to re-run CI. |
pgier
force-pushed
the
pulsar-perf-cli-refactor
branch
from
6fb9cc8 to
44f676d
Compare
|
Rebased on latest master again |
|
The pr had no activity for 30 days, mark with Stale label. |
pgier
force-pushed
the
pulsar-perf-cli-refactor
branch
2 times, most recently
from
fa77970 to
ceeb6d6
Compare
* reduce code duplication between perf clients * move common topic args and validation into new class PerformanceTopicListArguments * improve CLI arg validation * deprecate inconsistent args Signed-off-by: Paul Gier <paul.gier@datastax.com>
pgier
force-pushed
the
pulsar-perf-cli-refactor
branch
from
ceeb6d6 to
3e52d72
Compare
|
/pulsarbot rerun-failure-checks |
michaeljmarshall
approved these changes
May 22, 2023
lhotari
added
the
type/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some of the code in the pulsar-perf command line tools seems to be unnecessarily repetitive.
Modifications
This removes some code duplication in the pulsar-perf utilities by pushing the common CLI parsing logic up into the shared
PerformanceBaseArgumentsclass. This also deprecates some inconsistent CLI arg naming, and make some improvements to the CLI arg validation.Verifying this change
This change is already covered by existing tests, such as the pulsar-perf tests.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: pgier#8