Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][ci] Ignore docs_only logic for scheduled builds #19306

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jan 23, 2023

Motivation

For GitHub Actions workflows, the docs_only logic should be ignored for scheduled builds since it doesn't make sense to skip the build if the last commit contains only files that match the docs filter.

Modifications

If the event name is 'schedule', always set docs_only to false.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 2.12.0 milestone Jan 23, 2023
@lhotari lhotari self-assigned this Jan 23, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 23, 2023
@lhotari
Copy link
Member Author

lhotari commented Jan 23, 2023

/pulsarbot rerun-failure-checks

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

May or may not we update the docs_only filters in this patch; or I can do it later (given that site2 folder is moved).

@lhotari lhotari merged commit 8d81392 into apache:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants