Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][admin] Report earliest msg in partitioned backlog #19465

Merged

Conversation

teabot
Copy link
Contributor

@teabot teabot commented Feb 8, 2023

Master Issue: #19210

Motivation

It is not currently possible to gain visibility of the earliestMsgPublishTimeInBacklog on partitioned topics via the admin tool.

Modifications

  • Correctly compose earliestMsgPublishTimeInBacklog in Topic and Subscriber statistics implementations.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

Test coverage provided.

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: teabot#1

# Conflicts:
#	pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java
#	pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
#	pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
#	pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java
#	pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
#	pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/SubscriptionStatsImpl.java
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 8, 2023
@teabot teabot changed the title [Fix][Admin] Report earliest msg in partitioned backlog [fix][admin] Report earliest msg in partitioned backlog Feb 14, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Apr 6, 2023
@poorbarcode
Copy link
Contributor

Since we will start the RC version of 3.0.0 on 2023-04-11, I will change the label/milestone of PR who have not been merged.

  • The PR of type feature is deferred to 3.1.0
  • The PR of type fix is deferred to 3.0.1

So drag this PR to 3.0.1

@poorbarcode poorbarcode modified the milestones: 3.0.0, 3.1.0 Apr 10, 2023
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@codecov-commenter
Copy link

Codecov Report

Merging #19465 (83c34bb) into master (51c2bb4) will increase coverage by 39.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #19465       +/-   ##
=============================================
+ Coverage     33.50%   72.97%   +39.47%     
- Complexity    12053    31939    +19886     
=============================================
  Files          1613     1867      +254     
  Lines        126120   138598    +12478     
  Branches      13749    15224     +1475     
=============================================
+ Hits          42254   101145    +58891     
+ Misses        78332    29430    -48902     
- Partials       5534     8023     +2489     
Flag Coverage Δ
inttests 24.27% <0.00%> (+0.10%) ⬆️
systests 24.95% <0.00%> (?)
unittests 72.25% <100.00%> (+40.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/org/apache/pulsar/client/admin/Topics.java 72.50% <ø> (+40.00%) ⬆️
...mon/policies/data/stats/SubscriptionStatsImpl.java 94.11% <100.00%> (+25.42%) ⬆️
...sar/common/policies/data/stats/TopicStatsImpl.java 90.68% <100.00%> (+37.18%) ⬆️

... and 1517 files with indirect coverage changes

@Technoboy- Technoboy- merged commit c9fba5f into apache:master Jun 15, 2023
Technoboy- pushed a commit that referenced this pull request Jun 15, 2023
Technoboy- pushed a commit that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants