[improve][broker] PIP-192: Add large topic count filter #19613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heesung-sn
reviewed
Feb 27, 2023
| @@ -77,12 +79,18 @@ public BrokerLoadData generateLoadData() { | |||
| final var pulsarStats = pulsar.getBrokerService().getPulsarStats(); | |||
| synchronized (pulsarStats) { | |||
| var brokerStats = pulsarStats.getBrokerStats(); | |||
| var bundleStats = pulsarStats.getBundleStats(); | |||
| var topics = 0; | |||
| for (Map.Entry<String, NamespaceBundleStats> bundleStatsEntry : bundleStats.entrySet()) { | |||
There was a problem hiding this comment.
Can we define topics in BrokerStats and pre-aggregate this topic counts in updateStats?
public synchronized void updateStats(
ConcurrentOpenHashMap<String, ConcurrentOpenHashMap<String, ConcurrentOpenHashMap<String, Topic>>>
topicsMap) {
...
bundles.forEach((bundle, topics) -> {
NamespaceBundleStats currentBundleStats = bundleStats.computeIfAbsent(bundle,
k -> new NamespaceBundleStats());
currentBundleStats.reset();
currentBundleStats.topics = topics.size();
brokerStats.topics += topics.size(); //pre-aggregate
There was a problem hiding this comment.
Yes, pre-aggregate will be better. Updated.
heesung-sn
approved these changes
Feb 28, 2023
gaoran10
reviewed
Mar 1, 2023
Technoboy-
approved these changes
Mar 2, 2023
Technoboy-
added
type/feature
Demogorgon314
deleted the
Demogorgon314/PIP-192-Add_LargeTopicCountFilter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #16691
Motivation
We will start raising PRs to implement PIP-192, #16691
Modifications
This PR added a filter that can filter brokers based on the number of topics.
TODO
The broker load data might be delayed, so the max topic check might not be accurate.
Documentation
docdoc-requireddoc-not-neededdoc-complete