[improve] Make subscriptions on NonPersistentTopic non-durable #19741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dao-jun
changed the title
|
/pulsarbot run-failure-checks |
|
The pr had no activity for 30 days, mark with Stale label. |
gaoran10
requested review from
lhotari,
Technoboy-,
eolivelli,
315157973,
codelipenghui,
congbobo184 and
mattisonchao
Technoboy-
approved these changes
May 4, 2023
|
/pulsarbot rerun-failure-checks |
codelipenghui
approved these changes
May 8, 2023
lhotari
reviewed
Jun 5, 2023
| @@ -1121,6 +1121,7 @@ private ConsumerImpl<T> createInternalConsumer(ConsumerConfigurationData<T> conf | |||
| .timeout(1, TimeUnit.MILLISECONDS) | |||
| .build(); | |||
| configurationData.setBatchReceivePolicy(internalBatchReceivePolicy); | |||
| configurationData = configurationData.clone(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #19448
Motivation
See the PIP
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: dao-jun#1