Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] PIP-192: Make split admin API functional #19773

Conversation

Demogorgon314
Copy link
Member

@Demogorgon314 Demogorgon314 commented Mar 10, 2023

Master Issue: #16691

Motivation

Raising a PR to implement #16691, this PR makes the split admin API functional.

Modifications

  • Make the split admin API functional when enabling the ExtensibleLoadManager.
  • Support more split algorithm.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Demogorgon314 Demogorgon314 self-assigned this Mar 10, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 10, 2023
@Demogorgon314
Copy link
Member Author

Waiting for #19622 merged.

@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/PIP-192-spit-admin-api branch from cbed4ee to 5d0c9a5 Compare March 14, 2023 01:49
@Demogorgon314 Demogorgon314 marked this pull request as ready for review March 14, 2023 04:09
@Demogorgon314
Copy link
Member Author

@heesung-sn Please help review this PR.

@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/PIP-192-spit-admin-api branch from 5077bf7 to 1962c53 Compare March 16, 2023 00:42
@Technoboy- Technoboy- closed this Mar 16, 2023
@Technoboy- Technoboy- reopened this Mar 16, 2023
Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/PIP-192-spit-admin-api branch from 1962c53 to 05c9559 Compare March 18, 2023 10:09
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/PIP-192-spit-admin-api branch from 05c9559 to f8d33de Compare March 18, 2023 10:15
@Demogorgon314 Demogorgon314 merged commit 13d78dc into apache:master Mar 19, 2023
@Demogorgon314 Demogorgon314 deleted the Demogorgon314/PIP-192-spit-admin-api branch March 19, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants