-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] PIP-192: Make split admin API functional #19773
Merged
Demogorgon314
merged 1 commit into
apache:master
from
Demogorgon314:Demogorgon314/PIP-192-spit-admin-api
Mar 19, 2023
Merged
[improve][broker] PIP-192: Make split admin API functional #19773
Demogorgon314
merged 1 commit into
apache:master
from
Demogorgon314:Demogorgon314/PIP-192-spit-admin-api
Mar 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting for #19622 merged. |
cbed4ee
to
5d0c9a5
Compare
@heesung-sn Please help review this PR. |
heesung-sn
reviewed
Mar 14, 2023
...er/src/main/java/org/apache/pulsar/common/naming/SpecifiedPositionsBundleSplitAlgorithm.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateData.java
Show resolved
Hide resolved
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelTest.java
Show resolved
Hide resolved
.../main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateData.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Show resolved
Hide resolved
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Outdated
Show resolved
Hide resolved
heesung-sn
requested changes
Mar 15, 2023
...test/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java
Show resolved
Hide resolved
heesung-sn
approved these changes
Mar 15, 2023
5077bf7
to
1962c53
Compare
Technoboy-
approved these changes
Mar 16, 2023
gaoran10
reviewed
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gaoran10
approved these changes
Mar 16, 2023
1962c53
to
05c9559
Compare
05c9559
to
f8d33de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #16691
Motivation
Raising a PR to implement #16691, this PR makes the split admin API functional.
Modifications
ExtensibleLoadManager
.Documentation
doc
doc-required
doc-not-needed
doc-complete