[improve][schema] Add admin cli for testCompatibility #19974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
liangyepianzhou,
poorbarcode,
codelipenghui,
Technoboy- and
mattisonchao
github-actions
bot
added
doc-label-missing
and removed
doc-not-needed
|
@congbobo184 Please add the following content to your PR description and select a checkbox: |
congbobo184
added
doc-not-needed
github-actions
bot
added
doc-label-missing
and removed
doc-not-needed
github-actions
bot
added
doc-not-needed
tisonkun
approved these changes
Apr 1, 2023
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
Outdated
Show resolved
Hide resolved
lifepuzzlefun
approved these changes
Apr 1, 2023
poorbarcode
approved these changes
Apr 1, 2023
|
/pulsarbot rerun-failure-checks |
liangyepianzhou
approved these changes
Apr 1, 2023
Codecov Report
@@ Coverage Diff @@
## master #19974 +/- ##
============================================
- Coverage 72.89% 72.83% -0.07%
+ Complexity 31619 31598 -21
============================================
Files 1861 1861
Lines 137356 137362 +6
Branches 15117 15117
============================================
- Hits 100131 100044 -87
- Misses 29271 29346 +75
- Partials 7954 7972 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattisonchao
approved these changes
Apr 1, 2023
…CmdSchemas.java Co-authored-by: tison <wander4096@gmail.com>
…in_testCompatibility_cli
…/github.com/congbobo184/pulsar into congbobo184_add_admin_testCompatibility_cli
|
Since this patch is a help tools API, I cherry-picked it into |
poorbarcode
pushed a commit
that referenced
this pull request
May 7, 2023
<!-- ### Contribution Checklist - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. --> <!-- Either this PR fixes an issue, --> <!-- or this PR is one task of an issue --> <!-- If the PR belongs to a PIP, please add the PIP link here --> <!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md --> ### Motivation 1. add admin cli `testCompatibility` 2. add `admin.schemas().testCompatibility()` test ### Modifications 1. add admin cli `testCompatibility` 2. add `admin.schemas().testCompatibility()` test ### Verifying this change add test for it - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [x] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: <!-- ENTER URL HERE --> congbobo184#14 <!-- After opening this PR, the build in apache/pulsar will fail and instructions will be provided for opening a PR in the PR author's forked repository. apache/pulsar pull requests should be first tested in your own fork since the apache/pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. The tests will be run in the forked repository until all PR review comments have been handled, the tests pass and the PR is approved by a reviewer. --> (cherry picked from commit fce6e73)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
testCompatibilityadmin.schemas().testCompatibility()testModifications
testCompatibilityadmin.schemas().testCompatibility()testVerifying this change
add test for it
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository:
congbobo184#14